Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav Menu: Localize "No Parent" and menu item labels in nav menu options #7788

Conversation

yogeshbhutkar
Copy link

@yogeshbhutkar yogeshbhutkar commented Nov 13, 2024

Description

Updated raw strings to use i18n functions.

Trac ticket: https://core.trac.wordpress.org/ticket/62402

Screenshot of the fix:

Screenshot 2024-11-13 at 3 55 05 PM

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review November 13, 2024 10:15
Copy link

github-actions bot commented Nov 13, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props yogeshbhutkar, joedolson, desrosj.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@desrosj desrosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the two of strings use wp.i18n._x instead of wp.i18n.__ to provide additional context to translators? It may not be clear what is being translated.

@yogeshbhutkar
Copy link
Author

Thanks, @desrosj for suggesting an improvement here.

Sure, it would be better to provide context to the translator. I've added a patch for the same. Thanks.

@desrosj
Copy link
Contributor

desrosj commented Nov 18, 2024

@yogeshbhutkar one more change! @SergeyBiryukov confirmed in track that wp.i18n.sprintf() is actually the correct function.

@yogeshbhutkar
Copy link
Author

Thanks, @desrosj.

The changes are appended to the PR.

@joedolson joedolson self-requested a review November 19, 2024 22:42
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a change purely for readability, but otherwise this is good to go.

@desrosj
Copy link
Contributor

desrosj commented Nov 20, 2024

@desrosj desrosj closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants